-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: 2023q2: Wazuh: markup and other changes #213
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I think it means the set of Wazuh components. I guess it should be phrased better. Feel free to submit a better rewording and consider it approved by me if it is also approved by the original author. Thanks. |
Resolve freebsd#213 (comment) - where 'It' begins the fourth of five sentences in the second of two paragraph about ported components, reduce ambiguity. I took a hint from <https://www.freshports.org/security/wazuh-server#requiredrun>.
This comment was marked as resolved.
This comment was marked as resolved.
For consideration by (named contact) José Alonso Cárdenas Márquez. Changes suggested here include links to Elastic Stack and OpenSearch.
This comment was marked as resolved.
This comment was marked as resolved.
If you don't get an answer (or that's the wrong one) I still have an email address for him. |
This comment was marked as resolved.
This comment was marked as resolved.
@grahamperrin I agree with your changes. Just note a minor change there "Currently, all Wazuh components are ported: package:security/wazuh-manager[], package:security/wazuh-agent[], package:security/wazuh-server[], package:security/wazuh-indexer[], and package:security/wazuh-dashboard[]." Perphaps we could change it to "Currently, all Wazuh components are ported or adapted: ..." Really not all components were ported because I adapted wazuh-dashboard and wazuh-indexer ports using opensearch and opensearch-dashboards apps. Wazuh project forked those projects (currently from 2.6.0) for create their own versions but they applied just minor changes (login including Wazuh logo for example, changes some configuration paths, etc) but they have the same opensearch functionalities. |
Disambiguate the word 'It'. Express runtime dependencies. Clarify that alongside porting of components, there was adaptation. Remove a superfluous hard line break. One sentence per line. Other minor changes. Reviewed-by: acm, salvadore Approved-by: acm, salvadore Pull-request: #213
No description provided.