status: 2023q2: service jails: minor changes #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamperrin
commented
Jul 8, 2023
Comment on lines
+10
to
+11
| Service jails extend the man:rc[8] system to allow automatic jailing of rc.d services. | ||
| A service jail inherits the filesystem of the parent host or jail, but uses all other limits of the jail (process visibility, restricted network access, filesystem mounting permissions, sysvipc, ...) by default. |
There was a problem hiding this comment.
@netchild please, how is this for you?
Initially, I had difficulty thinking whether the first sentence should be plural (Service jails … allow) or singular (an extension … allows).
|
Do the wording as you think is best (non-native speaker here). My priority is the content, not the wording. |
lsalvadore
approved these changes
Jul 9, 2023
| @@ -1,27 +1,26 @@ | |||
| === Service Jails - automatic jailing of rc.d services | |||
| === Service Jails -- automatic jailing of rc.d services | |||
There was a problem hiding this comment.
While here, maybe a
switch automatic to a capital letter.
There was a problem hiding this comment.
If the heading must be entirely Americanised, then (from my UK perspective) I imagine:
=== Service Jails -- Automatic Jailing of rc.d Services
freebsd-git
pushed a commit
that referenced
this pull request
Jul 24, 2023
Approved by: carlavilla (mentor, implicit) Pull Request: #211
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markup.
Consistent use of lowercase.
Links to manual pages.
Other changes, minor.