Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: 2023q2: mfsBSD: correction, changes #207

Closed
wants to merge 0 commits into from

Conversation

grahamperrin
Copy link
Contributor

Correction: remove an apostrophe.

Markup, and a couple of minor changes.

@grahamperrin grahamperrin marked this pull request as ready for review July 8, 2023 02:51
Copy link
Contributor

@soobinrho soobinrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

grahamperrin added a commit to grahamperrin/freebsd-doc that referenced this pull request Jul 9, 2023
Resolve freebsd#207 (comment)

- mentors are named, but not as named contacts.
@grahamperrin

This comment was marked as resolved.

Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I only wonder about authors.adoc (see inline comment), but we can fix that later if needed.

freebsd-git pushed a commit that referenced this pull request Jul 13, 2023
PRs (plural of pull request) should be without an apostrophe. Whilst
correcting, expand the abbreviation.

Be concise with subheadings.

Move the project repository link up, to the Links: section, and reword
things appropriately.

include::shared/authors.adoc[]

- and use the inclusion as a point of reference.

Other minor changes, including markup.

Reviewed-by:  jrm, soobinrho
Approved-by:  salvadore, soobinrho
Pull-request: #207
@grahamperrin grahamperrin force-pushed the patch-15 branch 2 times, most recently from 5c3a844 to b53c91d Compare July 13, 2023 18:05
freebsd-git pushed a commit that referenced this pull request Jul 13, 2023
Adjacent _index.adoc will be the proper place for
include::shared/authors.adoc[]

Reported-by:  salvadore
Fixes:        219ac23 status: 2023q2: mfsBSD: correction, and a few minor changes
Pull-request: #207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants