Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status: 2023q2: mfsBSD building integration #192

Closed
wants to merge 1 commit into from
Closed

status: 2023q2: mfsBSD building integration #192

wants to merge 1 commit into from

Conversation

soobinrho
Copy link
Contributor

This is a 2023Q2 status report for the Integrate mfsBSD into the release building tools project.

I used the status report template, and made sure to follow the guidelines -- e.g. one sentence per line. Thanks everyone for handling all the status reports, and please let me know if there's anything you'd like me to add to this PR 👍 👍

pauamma
pauamma reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@pauamma pauamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM.

website/content/en/status/report-2023-04-2023-06/mfsbsd-building-integration.adoc Outdated Show resolved Hide resolved
lsalvadore
lsalvadore suggested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your report.

I suggest you add some context. I am unsure that all of our readers know about mfsBSD, I did not for example.

You could add one or two sentences to give a general definition and then point to a link (that you can also put in the links header) for readers wanting more details.

@soobinrho
Copy link
Contributor Author

soobinrho commented Jun 28, 2023 •
edited
Loading

Thanks for your report.

I suggest you add some context. I am unsure that all of our readers know about mfsBSD, I did not for example.

You could add one or two sentences to give a general definition and then point to a link (that you can also put in the links header) for readers wanting more details.

Completely agreed. I'll make an additional commit containing an explanation on what is mfsBSD. Thank you, @lsalvadore for the suggestion!

soobinrho added a commit to soobinrho/freebsd-doc that referenced this pull request Jun 28, 2023
@soobinrho
doc: add explanation on mfsBSD and the location of the project reposi…
0395d86 
…tory

Addresses feedback from @lsalvadore on freebsd#192.

Signed-off-by: Soobin Rho <[email protected]>
@soobinrho soobinrho force-pushed the status-report-mfsBSD-building-integration branch from 79ab824 to 61d8d1a Compare June 28, 2023 11:50
soobinrho added a commit to soobinrho/freebsd-doc that referenced this pull request Jun 28, 2023
@soobinrho
doc: add explanation on mfsBSD and the location of the project reposi…
226c042 
…tory

Addresses feedback from @lsalvadore on freebsd#192.

Signed-off-by: Soobin Rho <[email protected]>
@soobinrho soobinrho force-pushed the status-report-mfsBSD-building-integration branch from 61d8d1a to f727b38 Compare June 28, 2023 12:00
@soobinrho
Copy link
Contributor Author

soobinrho commented Jun 28, 2023 •
edited
Loading

I rebased this PR branch based on the upstream/main branch since there's been a few new commits.

git remote add upstream https://github.com/freebsd/freebsd-doc.git
git fetch upstream
git rebase upstream/main
git push -f

lsalvadore
lsalvadore suggested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes and this is ready.

website/content/en/status/report-2023-04-2023-06/mfsbsd-building-integration.adoc Show resolved Hide resolved
website/content/en/status/report-2023-04-2023-06/mfsbsd-building-integration.adoc Outdated Show resolved Hide resolved
website/content/en/status/report-2023-04-2023-06/mfsbsd-building-integration.adoc Outdated Show resolved Hide resolved
website/content/en/status/report-2023-04-2023-06/mfsbsd-building-integration.adoc Outdated Show resolved Hide resolved
website/content/en/status/report-2023-04-2023-06/mfsbsd-building-integration.adoc Outdated Show resolved Hide resolved
@lsalvadore
Copy link
Member

@sergio-carlavilla , @dbaio: can I proceed with the commit once this is ready? do you mentor approve?

Thanks.

soobinrho added a commit to soobinrho/freebsd-doc that referenced this pull request Jun 28, 2023
@soobinrho
doc: addresse feedback from @lsalvadore on freebsd#192
d778e71
soobinrho added a commit to soobinrho/freebsd-doc that referenced this pull request Jun 28, 2023
@soobinrho @pauamma
doc: add status report for mfsBSD building integration
7922cd2 
doc: fix typos ('Sponsored : ' -> 'Sponsor: ')
doc: add explanation on mfsBSD and the location of the project repository
doc: split into 3 sentences for better flow
doc: add a missing set of brackets "[]" to a link
doc: add emails of mentors and change the first person (I) to the third person
doc: addresse feedback from @lsalvadore on freebsd#192

Sponsored by: Google, Inc. (GSoC 2023)
Co-authored-by: Pau Amma <[email protected]>
Signed-off-by: Soobin Rho <[email protected]>
@soobinrho soobinrho force-pushed the status-report-mfsBSD-building-integration branch from d778e71 to 7922cd2 Compare June 28, 2023 20:00
@soobinrho
Copy link
Contributor Author

Thanks @lsalvadore again for the suggestions! I've implemented all the suggestions. Also, as suggested by my mentors @Jehops and @jurajlutter, I've squashed all the previous commits into one commit 👍 👍

@soobinrho soobinrho changed the title doc: add status report for mfsBSD building integration status: 2023q2: mfsBSD building integration Jun 28, 2023
soobinrho added a commit to soobinrho/freebsd-doc that referenced this pull request Jun 28, 2023
@soobinrho @pauamma
status: mfsBSD building integration: initial commit
7060484 
doc: fix typos ('Sponsored : ' -> 'Sponsor: ')
doc: add explanation on mfsBSD and the location of the project repository
doc: split into 3 sentences for better flow
doc: add a missing set of brackets "[]" to a link
doc: add emails of mentors and change the first person (I) to the third person
doc: addresse feedback from @lsalvadore on freebsd#192
doc: addresse feedback from @Jehops on freebsd#192

Sponsored by: Google, Inc. (GSoC 2023)
Co-authored-by: Pau Amma <[email protected]>
Signed-off-by: Soobin Rho <[email protected]>
@soobinrho soobinrho force-pushed the status-report-mfsBSD-building-integration branch from 7922cd2 to 7060484 Compare June 28, 2023 20:23
@soobinrho soobinrho requested a review from Jehops June 28, 2023 20:24
soobinrho added a commit to soobinrho/freebsd-doc that referenced this pull request Jun 28, 2023
@soobinrho @pauamma
status: 2023q2: mfsBSD building integration: initial commit
8d8928d 
doc: fix typos ('Sponsored : ' -> 'Sponsor: ')
doc: split into 3 sentences for better flow
doc: add explanation on mfsBSD and the location of the project repository
doc: add a missing set of brackets "[]" to a link
doc: add emails of mentors and change the first person (I) to the third person
doc: addresse feedback from @lsalvadore on freebsd#192
doc: addresse feedback from @Jehops on freebsd#192

Sponsored by: Google, Inc. (GSoC 2023)
Co-authored-by: Pau Amma <[email protected]>
Signed-off-by: Soobin Rho <[email protected]>
@soobinrho soobinrho force-pushed the status-report-mfsBSD-building-integration branch from 7060484 to 8d8928d Compare June 28, 2023 20:28
@soobinrho
Copy link
Contributor Author

All of this would not have been possible without the creator of mfsBSD. Thank you @mmatuska for creating and maintaining mfsBSD!

@soobinrho @pauamma
status: 2023q2: mfsBSD building integration: initial commit
871dab0 
doc: fix typos ('Sponsored : ' -> 'Sponsor: ')
doc: split into 3 sentences for better flow
doc: add explanation on mfsBSD and the location of the project repository
doc: add a missing set of brackets "[]" to a link
doc: add emails of mentors and change the first person (I) to the third person
doc: addresse feedback from @lsalvadore on freebsd#192
doc: addresse feedback from @Jehops on freebsd#192

Sponsored by: Google, Inc. (GSoC 2023)
Co-authored-by: Pau Amma <[email protected]>
Signed-off-by: Soobin Rho <[email protected]>
@soobinrho soobinrho force-pushed the status-report-mfsBSD-building-integration branch from 8d8928d to 871dab0 Compare June 29, 2023 13:11
@soobinrho
Copy link
Contributor Author

Update: Force-pushed. I had to rebase on top of the last three commits added e4674f0 80f13b0 197a532

pauamma
pauamma approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@pauamma pauamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

lsalvadore
lsalvadore approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@sergio-carlavilla @dbaio : Do you mentor approve the commit?

@soobinrho : I am a mentored doc committer, I need to get mentor approval before committing your report to the doc repository.

@dbaio
Copy link
Member

dbaio commented Jun 30, 2023

Approved.

@sergio-carlavilla @dbaio : Do you mentor approve the commit?

Yes, please, go ahead.

@dbaio dbaio added the ready label Jun 30, 2023
freebsd-git pushed a commit that referenced this pull request Jul 4, 2023
@lsalvadore
Status/2023Q2/mfsdbsd.adoc: Add report
c6d6c48 
Reviewed by:	jrm, status (Pau Amma <[email protected]>)
Approved by:	dbaio (mentor)
Pull Request:	#192
@soobinrho soobinrho deleted the status-report-mfsBSD-building-integration branch July 6, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauamma pauamma pauamma approved these changes

@lsalvadore lsalvadore lsalvadore approved these changes

@Jehops Jehops Awaiting requested review from Jehops

Assignees
No one assigned
Labels
ready status report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soobinrho @lsalvadore @dbaio @pauamma @Jehops @sergio-carlavilla