Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): add solutions to first 3 debugging challenges #304

Conversation

joshalling
Copy link
Member

Description

This PR adds solutions to the first three js debugging challenges. It is related to #250. As I have time will will submit more PRs to get the rest of the solutions in there.

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@scissorsneedfoodtoo
Copy link
Contributor

Everythin LGTM, too! Thank you for adding these solutions, @joshalling.

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit c2e5794 into freeCodeCamp:dev Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants