-
-
Notifications
You must be signed in to change notification settings - Fork 59
[WIP] Add maps for location, gender, ethnicity and age #54
Conversation
Add maps for location, gender, ethnicity, age
|
I've fixed the excessive file loading and the flickering has stopped even thought I haven't put any transitions in, so looks like the DOM is quick enough. |
@krisgesling looks great and I like tabs colors! And yes, it fits my screen now. Also after my PR the navbar will be even smaller, so all good 👍
Yes, it's better, but as I said, user research will be the best decision. We can just ask campers about it, when it's done. Also we can change the "water" color to transparent, and put the color legend inside the map. Map 1Map 2Map 3Map 4I like map 1 & 3, but others also good. |
Btw, we need to work a bit more on mobile version. Don't worry abt nav, it's already fixed in my PR. If we set "water" color to transparent, the problem with Location tab should be fixed by itself. And you can probably make map wider. Definitely left side 10px, may be right, too. |
Changes made:
In regard to scroll zoom this is currently what allows mobile users to pinch zoom. Also on mobile devices while scrolling down the page a similar thing happens when you try swiping on the map you move the map instead of scrolling the page. So I can replace them with arrows and +/- buttons but it will be very slow navigating the map particularly on a mobile device. |
Great! Looks awesome on all my screens! 👍 A few small issues: Groups
Probably for ethnicity map we can separate Canada(27%), USA (31%) and Nepal (30%) from South Africa (63%), Thailand (52%), Malaysia (58%), South Korea (54%), etc. E.g. 0-10%, 11-15%, 16-20%, 21%-35%, 36+% ColorsAlso colors are very similar at ethnicity and gender maps, which makes it hard to read. (Especially last 2 colors) Good example is Age map, because it goes from very light color to very dark one, so it's very easy to spot the differences between countries, and that's exactly the reason to make a country breakdown. |
Better make it right side & smaller & italic & opacity same like at the bar charts v2.1 |
No description provided.