Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFOS aarch64 fixes #61

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Conversation

Karry
Copy link
Contributor

@Karry Karry commented May 29, 2021

Necessary fixes for aarch64 build with recent SFOS SDK ( #60 ). See commit messages for details.

Karry added 3 commits May 29, 2021 19:15
NOTIFY signal has to be defined in the same class as the property
see https://bugreports.qt.io/browse/QTBUG-7684
it should be /usr/lib, even when LIBDIR is /usr/lib64
@fredldotme
Copy link
Owner

LGTM, thanks!

Keep in mind though that I'm not possessing any aarch64-capable SfOS device right now. So it would be interesting to see if you're interested in distributing the application using a "blessed" account or something.

@fredldotme fredldotme merged commit 1fde725 into fredldotme:master Jun 12, 2021
@Karry Karry deleted the sfos-aarch64-fixes branch June 14, 2021 05:50
@Karry
Copy link
Contributor Author

Karry commented Jun 14, 2021

Hi. I published aarch64 build on Openrepos meanwhile. But it is just temporary solution from my point of view, all architectures should be in one repository I think. It is not so big problem that you don't have 64 bit phone yet, when it compiles, it works usually :-) And you have big group of loyal testers, including me.

@fredldotme
Copy link
Owner

It's just that I'm doing so much work at the moment, from working on Ubuntu Touch to porting QML Creator and GhostCloud to Apple platforms.
I just don't know if I have the time to continue working on the SfOS part of GhostCloud for now, so I'm looking for someone who would like to join the GhostCloud team. :)

@fredldotme
Copy link
Owner

@Karry btw, would you allow me to relicense your changes to src/common as LGPLv2.1?
I plan to release some variant of GhostCloud to Apple platforms, which are only compatible to LGPLv2.1.

@Karry
Copy link
Contributor Author

Karry commented Jun 16, 2021

No problem, I am fine with LGPLv2.1 license :-) I am just curious, GPL-licensed applications cannot be distributed for Apple?

@fredldotme
Copy link
Owner

The GPLv2 and v3 allow certain freedoms that the Mac App Store would prevent you from making use of. LGPLv2.1 is fine though, at least VLC seems to have succeeded with that.

And thanks for relicensing that part of your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants