Code Comments #7
Conversation
| @@ -52,6 +68,7 @@ private void configureBindings() { | |||
|
|
|||
| //Positive x moves bot forwards and positive y moves bot to the left | |||
| driveSubsystem.setDefaultCommand(new RunCommand(() -> { | |||
| // Why do you need to check if teleop is enabled here? | |||
There was a problem hiding this comment.
Yeah I think it's probably unecessary so I got rid of it
| private final DriveSubsystem driveSubsystem = new DriveSubsystem(); | ||
|
|
||
| // I think you should use the april tags and get the pose from that. Then you can have a command for every tag |
There was a problem hiding this comment.
I like the idea of using a command for each april tag, I was planning on adding that soon. I don't know how useful accessing the exact pose of the tags is though, because we don't want to move on top of them, we want to be some position next to them which could vary from tag to tag. The way I thought was best to do this was to have a position input that we adjust as needed for each tag command. Is there some benefit to using the april tag positions instead? I would think that we would need to still end up putting in arbitrary constants specifying how far away to be
|
I've started to look through these, and I'll come back to them when I get the chance hopefully tomorrow |
No description provided.