AArch32 and AArch64 minus SIMDe fixes #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard uses of the new `simdFilterARM` kernel by checking that `TARGET_SIMD_X86` is defined, since otherwise the SIMD-everywhere based kernel is not available and will fail to compile.
Since 6a5cfa8 the AArch32 code fails to build due to use of `*_high_*` and other intrinsics which are only available on AArch64. Switch these to the portable versions already defined in `sum_neon.h`. Additionally fix a typo in InterPredARM.h. Also adjust code style to match the prevailing style elsewhere in the library.
|
Thanks! |
|
Hi @adamjw24 I'm not sure what the current CI/pre-commit setup looks like, do you think it would be possible to add some additional checks to ensure that compilation on 32-bit and 64-bit Arm + the various CMake SIMD configure option combinations continues to work? |
|
While its a fair request, I think this is a very artificial use-case. In addition to the GitHub CI, we have an internal runner with around 30 builds, 10 of them also running the tests. I think stuff like here will happen occasionaly and can than be fixed. We'll put more considration into the use case the next time tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like #473 broke the VVenC build when building both for AArch32 and also for AArch64 if SIMDe-based kernels are not enabled. This is easily fixed through a few small tweaks:
Use the existing helper functions in
sum_neon.hand avoiding*_high_*and other intrinsics that are not available for 32-bit Arm platforms.Guard the SIMDe-enabled kernels with
defined( TARGET_SIMD_X86 )checks to avoid including these kernels if they are not available.Additionally fix a typo in
InterPredARM.hto refer to voidInterPredInterpolationinstead ofTCoeffOps.