incorrect multiplication in the Moffat profile function #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @CheerfulUser for pointing out this pretty silly mistake. You're correct in that it only modifies the amplitude of the moffat profile, and not its shape. Probably why this error has existed for so long! I am currently trying to come up with a scheme to handle this error for those PSF files created before fixing this bug. At least something better than just warning people. Once I have a solution I will merge. thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One multiplication in the Moffat profile should be a division. This should have no effect on the results as it just changes the amplitude of the profile and not the shape.