feat(wiki): markdown editor #265
Conversation
AyshaHakeem
commented
Sep 7, 2024
AyshaHakeem
commented
- Add a patch to convert 'content' field's value in existing Wiki Page records from Rich Text (HTML) to Markdown
- Update the 'content' field's type in the Wiki Page Doctype to 'Markdown Editor’
- Convert existing editor to markdown in the frontend
- Add a patch to convert 'content' field's value in existing Wiki Page records from Rich Text (HTML) to Markdown - Update the 'content' field's type in the Wiki Page Doctype to 'Markdown Editor’ - Convert existing editor to markdown in the frontend
Wiki
|
||||||||||||||||||||||||||||
| Project |
Wiki
|
| Branch Review |
feat-markdown-editor
|
| Run status |
|
| Run duration | 00m 23s |
| Commit |
|
| Committer | Aysha |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
|
@AyshaHakeem Can you also fix the failing cypress test. Also there are some linter issue |
|
Great work by the way👌🏻 Suggestion: Always try to push in multiple and small commits instead of pushing everything in one commit. It will be easier for reviewer to read your PR. |
|
I was testing and tried to create CRM's Introduction page which works perfectly. But I have added a video tag is not visible in edit mode after saving. It is visible in desk but not in portal 
Desk: Portal: |
- Edit JavaScript code to improve page creation functionality - Fix failing UI tests
|
Thank you Shariq for reviewing! @shariquerik Screen.Recording.2024-09-10.at.7.34.03.PM.mov |
- Ensure tags like <iframe>, <video>, etc. are retained when converting Wiki content to markdown.
|
Hello, my team is working on documentation and more comforatble with rich text. Note: Just wondering why are we changing the editor? |
Markdown is a standard way of writing docs hence the switch. |
OK 👌 just want to get confirmed. Thanks! |
|
@shariquerik we do have problem with wiki writing pane for our local language.
This is actually happen in any coding syle pane (i.e., system console) but not rich text. In the pic you will see the cursor position not get along with the real display. Any hint to solve this? |
|
May be the problem with ace editor. |
Definitly not nice. I love markdown, but I cannot expect from all employees to learn it. Really considered the app as it blends in with the users from ERPNext, but I guess I skip it and rather have the people login into a new tool than writing markdown. Tell someone from HR or the production worker to document in markdown...they will rather quit the job. I don't need the wiki for my software people. I need a software for my peoples knowledge. Easy and quick. Anything else is wired. |
