Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit): use ruff #261

Merged
merged 5 commits into from
Aug 14, 2024
Merged

chore(pre-commit): use ruff #261

merged 5 commits into from
Aug 14, 2024

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Aug 14, 2024

  • build: align with upstream
  • build: update pre-commit
  • chore: run ruff
  • chore: ignore blame on reformat

Please consider this PR. This currently blocks builds on Frappix (for the old build tooling):

Instead of cherry picking things, I just decided to summary-overhaul with latest upstream best practice.

This implicated updating pre-commit and running ruff on the entire repo.

@BreadGenie please try to have a look asap as for me this is maintenance wise a "ticking time bomb".

@BreadGenie BreadGenie changed the title fix/build chore(pre-commit): use ruff Aug 14, 2024
Copy link

cypress bot commented Aug 14, 2024



Test summary

5 0 0 0Flakiness 0


Run details

Project Wiki
Status Passed
Commit 0e37ef0 ℹ️
Started Aug 14, 2024 2:00 PM
Ended Aug 14, 2024 2:01 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@BreadGenie
Copy link
Member

@blaggacao can you fix pip-audit? I think it'll suffice to change it to

pip-audit -desc on .

in the linters.yml file

@blaggacao
Copy link
Contributor Author

@BreadGenie Thanks for the hint! Please try CI again with 3ef41cb

@BreadGenie BreadGenie merged commit e1f3521 into frappe:master Aug 14, 2024
7 checks passed
@blaggacao blaggacao deleted the fix/build branch August 14, 2024 18:25
@blaggacao
Copy link
Contributor Author

Thanks a lot! Revert of Patch in Frappix is also merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants