fix(Payroll): Change "Preview Salary Slips" dropdown to autocomplete #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
changed the title
ruchamahabal
approved these changes
Oct 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
…935) Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 254ae34)
ruchamahabal
added a commit
that referenced
this pull request
Oct 5, 2023
…(backport #935) (#940) Co-authored-by: Rucha Mahabal <[email protected]> Co-authored-by: Niraj Gautam <[email protected]>
|
I ran pre-commit, still it seems formatting is not applied properly. What could be the issue? |
|
@niraj2477 pre-commit only takes care of .py files. I will soon add auto-formatting using prettier for client side |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
# [14.13.0](v14.12.1...v14.13.0) (2023-10-06) ### Bug Fixes * absent marking fails if shift's end date & actual end date are different ([d6106a3](d6106a3)) * absent marking for missing attendance dates fails for an older assignment date ([4743adf](4743adf)) * Add close button in goal view ([fc26b2d](fc26b2d)) * error while selecting an employee when `salary_slip_based_on_timesheet` is unchecked ([#936](#936)) ([ea77ff2](ea77ff2)) * handle false positive cases for shift fetching in shift boundaries ([97ada07](97ada07)) * incorrect attendance date for different start & actual start dates ([0aa31ee](0aa31ee)) * Overflow error for date operation when day changes ([dc8ad3b](dc8ad3b)) * **Payroll:** Change "Preview Salary Slips" dropdown to autocomplete (backport [#935](#935)) ([#940](#940)) ([63817f7](63817f7)) * shift fetch fails if shift's end date & actual end date are different ([7cb995e](7cb995e)) * shift fetch fails in before shift margin if shift's start & actual start date are different ([9125c75](9125c75)) * status button groups & formatting ([9370583](9370583)) * Update list view & json schema ([c7e519f](c7e519f)) * Update set_status function ([e002fa9](e002fa9)) ### Features * Add status dropdown button ([f766d1a](f766d1a)) ### Performance Improvements * use generator fn for date range to find prev/next assignment ([db5e7d8](db5e7d8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #929