chore: release v14 #909
Merged
chore: release v14 #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current frappe.safe_eval transforms code so if you have nested iterations with too much depth then it can hit recursion limit of python. There's no workaround for this and people need large formulas in some countries, so this is alternate implementation for that. (cherry picked from commit 7fb3508) # Conflicts: # hrms/payroll/doctype/salary_slip/salary_slip.py # hrms/payroll/doctype/salary_slip/test_salary_slip.py
(cherry picked from commit 68e0399)
fix: alternate formula eval implementation (backport #902)
) Co-authored-by: Rucha Mahabal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## version-14 #909 +/- ##
==============================================
+ Coverage 73.53% 73.62% +0.09%
==============================================
Files 193 193
Lines 9972 9999 +27
==============================================
+ Hits 7333 7362 +29
+ Misses 2639 2637 -2
|
|
🎉 This PR is included in version 14.11.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated Release.