Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compensatory leave request for Half Day & WFH #906

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

ruchamahabal
Copy link
Member

Compensatory Leave Request does not work for a half day. It only checks for attendance records with "Present" status.
Employee worked for half day on 15th so this is a valid comp off

image

@codecov-commenter
Copy link

Codecov Report

Merging #906 (be1452f) into develop (a376f06) will increase coverage by 0.05%.
Report is 6 commits behind head on develop.
The diff coverage is 96.66%.

@@             Coverage Diff             @@
##           develop     #906      +/-   ##
===========================================
+ Coverage    73.11%   73.16%   +0.05%     
===========================================
  Files          195      195              
  Lines        10175    10202      +27     
===========================================
+ Hits          7439     7464      +25     
- Misses        2736     2738       +2     
Files Changed Coverage
hrms/setup.py ø
hrms/payroll/doctype/salary_slip/salary_slip.py 96.00%
...satory_leave_request/compensatory_leave_request.py 100.00%

@ruchamahabal ruchamahabal merged commit 337e6ec into frappe:develop Sep 22, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Sep 22, 2023
ruchamahabal added a commit that referenced this pull request Sep 22, 2023
frappe-pr-bot pushed a commit that referenced this pull request Sep 25, 2023
## [14.11.1](v14.11.0...v14.11.1) (2023-09-25)

### Bug Fixes

* alternate formula eval implementation ([59fbad6](59fbad6))
* compensatory leave request for Half Day & WFH (backport [#906](#906)) ([#907](#907)) ([037d12e](037d12e))
* required_apps ([#911](#911)) ([4f4bbe0](4f4bbe0))
* use single underscore fn & fix assertions in tests ([2baea34](2baea34))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants