fix: alternate formula eval implementation #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current frappe.safe_eval transforms code so if you have nested iterations with too much depth then it can hit recursion limit of python. There's no workaround for this and people need large formulas in some countries, so this is alternate implementation for that.
Codecov Report
@@ Coverage Diff @@
## develop #902 +/- ##
===========================================
+ Coverage 73.07% 73.12% +0.05%
===========================================
Files 195 195
Lines 10175 10199 +24
===========================================
+ Hits 7435 7458 +23
- Misses 2740 2741 +1
|
ruchamahabal
added a commit
that referenced
this pull request
Sep 22, 2023
fix: alternate formula eval implementation (backport #902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current frappe.safe_eval transforms code so if you have nested conditions with too much depth then it can hit recursion limit of python.
There's no workaround for this and people need large formulas in some
countries, so this is alternate implementation for that.