Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PWA): Leaves, Expense Claims, & Employee Advances #807

Merged
merged 92 commits into from
Aug 22, 2023
Merged

feat(PWA): Leaves, Expense Claims, & Employee Advances #807

merged 92 commits into from
Aug 22, 2023

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Aug 21, 2023 •
edited
Loading

Continuing #595

Leave History

Kapture.2023-08-09.at.09.12.16.mp4
image
Leave Application
Kapture.2023-08-09.at.09.18.16.mp4
image
Form Validations
Kapture.2023-08-09.at.09.23.17.mp4
image
Expense Claims Dashboard
Kapture.2023-08-09.at.09.33.44.mp4
image image image
Expense Claim List
Kapture.2023-08-09.at.09.41.43.mp4
Expense Claim Form
Kapture.2023-08-09.at.09.51.31.mp4
image image image
  • Form view
    • Form Fields
    • Tabs
    • Validations + Form Scripts
      • Leaves
      • Claims + child table
      • Advances
  • List views with filters
  • Attachments in forms - picked up parts of it from https://github.com/frappe/changemakers
  • Claim Dashboard
  • Action sheets - approval & submission action separation
  • Unified Request Panel
  • Fixes

no-docs

@ruchamahabal
feat: set up form, list routing for leaves
3900db2
@ruchamahabal
feat: Basic Formview and Fields Rendering
125a1f2
@ruchamahabal
refactor(UX): show title with docname in link fields
b1aab2b
@ruchamahabal
fix: bind attributes for fieldtypes
90d5e51
@ruchamahabal
feat: set up watchers for form fields to add scripts
48d21e3
@ruchamahabal
refactor: filter form fields to reduce noise
d969712
@ruchamahabal
feat: show error messages for field validations
9637b51
@ruchamahabal
feat: Leave Application form scripts - set, validate values
61513a7
@ruchamahabal
refactor: get all leave approval details in a single request
bf791e2
@ruchamahabal
fix: handle empty states in views
1b8b7c9
@ruchamahabal
feat: populate leave approvers and allocated leave types
7ce01d4
@ruchamahabal
feat: create document
5c0cb9a
@ruchamahabal
feat: disable save button until all the required fields are filled
9048f2b
@ruchamahabal
chore: bulk format code using prettier
920daa1
@ruchamahabal
chore: ignore formatting changes in blame
1675982
@ruchamahabal
fix: socketio port in config
4f4bee2
@ruchamahabal
feat: Edit form/Saved form view
d342101 
- edit form functionality added

- show doc ID in header

- make fields read-only if emp is viewing some other employee's leave application
@ruchamahabal
feat: set leave application To Date based on From Date
78d320f
@ruchamahabal
fix: make form header sticky
907a4c0
@ruchamahabal
feat: List view
8f6a380 
- fetch documents as per tab: team's requests or your own

- link to individual records

- refactor request panel and list item components for dynamic use
@ruchamahabal
feat: status filter in list view
dab6d63
@ruchamahabal
feat: field level filters with conditions
4745421 
- extract `ListFilterActionSheet` component

- implement clear filters

- fix filter button style
@ruchamahabal
feat: add expense claim routes and refactor leave routing
97c773d
@ruchamahabal
feat: Expense Claim summary in dashboard
625504c
@ruchamahabal
feat: show recent expenses in Claims dashboard
f5c3170 
- show claim types, amount, dates in list item

- add resource for company wise currency symbols as its needed frequently
@ruchamahabal
feat: show Employee Advance Balance
350901e 
- add routes for Employee Advance views
@ruchamahabal
feat: show claim status along with approval status
4b732f3
@ruchamahabal
feat: Expense Claim list view
7350f94
@ruchamahabal
refactor(UX): cleaned up Expense Claim form
e49dea9 
- added tabs and better field grouping

- removed unused hidden fields - title, email_id
@ruchamahabal
feat: tabbed view in forms
e808a39
@ruchamahabal
feat(Edit doc): delete, upload & fetch existing attachments
ab9a0e1
@ruchamahabal
feat: show status indicator on saved doc
6ee4242
@ruchamahabal
refactor: move expense claim list config to doctype settings
baff176
@ruchamahabal
feat: show colored status badge on saved form
a04cff3
@ruchamahabal
feat: guess status color if doctype states are not configured
d409413
@ruchamahabal
fix: order lists by modified desc
692b039
@ruchamahabal
fix(form routing): re-route to saved form view on new record insertion
da419f4
@ruchamahabal
feat: submit & cancel doc
9b5614e
@ruchamahabal
fix: set submitted/cancelled form as read-only
900a370
@ruchamahabal
fix(forms): respect perms for submit & cancel
7d496e3
@ruchamahabal
refactor: cleanup employee advance form
7ee2b54
@ruchamahabal
feat: Employee Advance form
45b879f
@ruchamahabal
feat: employee advance list view
a50e133
@ruchamahabal
fix: add attachment links
432b39c
@ruchamahabal
feat: unified Request Panel - Leaves + Claims
68bab37 
refactor: accept `RequestList` component as prop instead of importing all components
@ruchamahabal
refactor: action sheets for requests
b253e56
@ruchamahabal
feat: Expense Claim Request Action Sheet
a4fad8d
@ruchamahabal
feat: add form link in action sheet
0057c04
@ruchamahabal
refactor: Approval/Rejection -> Submission/Cancellation flow
2d2dab6 
- don't implicitly submit doc, approve and add a separate action for submission
@ruchamahabal
fix: links for employee advance docs & list view
6b8be22
@ruchamahabal
fix: add quick links
2db5028
@ruchamahabal ruchamahabal merged commit 28c9216 into frappe:mobile Aug 22, 2023
5 of 6 checks passed
@ruchamahabal ruchamahabal mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruchamahabal