fix: add missing project field in expense taxes and map project in gl entries #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
fix-acc-dimensions
branch
from
3421362
to
9fd9e98
Compare
ruchamahabal
force-pushed
the
fix-acc-dimensions
branch
from
4653a5a
to
b01104c
Compare
|
Tests passed. Uploading coverage data failed. Merging |
ruchamahabal
added a commit
that referenced
this pull request
Jun 26, 2023
fix: add missing project field in expense taxes and map project in gl entries (backport #627)
ruchamahabal
added
the
backport version-13-hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #623
The default accounting dimension "project" was missing in the Expense Claim Detail child table. Hence the project was not getting mapped against child table gl entries.
Also, added a project field to the tax table and mapped it in gl entry creation.