Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: index shift type & employee in shift assignment #622

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jun 23, 2023

Shift Assignment queries were doing a full table scan.
Index shift type & employee in shift assignment.

@codecov-commenter
Copy link

Codecov Report

Merging #622 (e81f001) into develop (591b9e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #622   +/-   ##
========================================
  Coverage    72.97%   72.97%           
========================================
  Files          192      192           
  Lines         9909     9910    +1     
========================================
+ Hits          7231     7232    +1     
  Misses        2678     2678           
Impacted Files Coverage Δ
...ms/hr/doctype/shift_assignment/shift_assignment.py 93.29% <100.00%> (+0.03%) ⬆️

@ruchamahabal ruchamahabal changed the title perf: index most queried fields in shifts and attendance perf: index shift type & employee in shift assignment Jun 26, 2023
@ruchamahabal ruchamahabal marked this pull request as ready for review June 26, 2023 07:33
@ruchamahabal ruchamahabal merged commit 7de67d4 into frappe:develop Jun 26, 2023
6 of 7 checks passed
mergify bot pushed a commit that referenced this pull request Jun 26, 2023
ruchamahabal added a commit that referenced this pull request Jun 26, 2023
frappe-pr-bot pushed a commit that referenced this pull request Jun 26, 2023
## [14.4.5](v14.4.4...v14.4.5) (2023-06-26)

### Bug Fixes

* add missing accounting dimension field for project in Expense Claim Detail (backport [#623](#623)) ([#624](#624)) ([e0443af](e0443af))
* add missing project field in expense taxes and map project in gl entries ([e410213](e410213))
* employee link fields in payroll reports (backport [#619](#619)) ([#620](#620)) ([e8a57a2](e8a57a2))

### Performance Improvements

* index shift type & employee in shift assignment (backport [#622](#622)) ([#625](#625)) ([331216b](331216b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants