fix: filter employees based on company in Salary Structure Assignment

[saurabh6790]

Issue:

On Salary Structure Assignment, employee field not considering company

• For employee HR-EMP-00010, the company is set to Test Comp
  

• On Salary Structure Assignment, the company is set as Frappe Technologies Pvt Ltd. though the system is allowing to select employee HR-EMP-00010
  

Fix

Filter employee selection based on company

[ruchamahabal]

I think the company should be fetched from the Employee doc. It's a read-only field and it automatically sets the default company.

Doesn't make sense to add a filter from a read-only field

If I want to create a salary structure assignment for some employee from another company (other than the default one), how do I do that if this filter is set?

Idk why is it a read-only field without fetch-from in the first place 🫠 Weird

[saurabh6790]

@ruchamahabal

• General flow, we create Salary Structure Assignment from Salary Structure. So the system maps company from Salary Structure. On Salary Structure the company field is editable.
• We can add company filter, by checking if the Salary Structure Assignment is being created against Salary Structure.

[mujeerhashmi]

I think the company should be fetched from the Employee doc. It's a read-only field and it automatically sets the default company.

I faced this issue only today for multi-company setup. My expectation was company should be fetched from employee & should not be read-only. At the same time when employee is getting selected with company already set, then filters should apply.

If I want to create a salary structure assignment for some employee from another company (other than the default one), how do I do that if this filter is set?

Idk why is it a read-only field without fetch-from in the first place 🫠 Weird

Yes, The company should not be read-only.

[ruchamahabal]

Closing in favour of a better fix