-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Do not consider payroll frequency in timesheet based payroll #612
refactor: Do not consider payroll frequency in timesheet based payroll #612
Conversation
… based on timesheet
c87f134
to
5ab38dc
Compare
…sheet-based-payroll
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #612 +/- ##
===========================================
+ Coverage 72.47% 72.55% +0.08%
===========================================
Files 193 194 +1
Lines 9947 9980 +33
===========================================
+ Hits 7209 7241 +32
- Misses 2738 2739 +1
|
9d82e82
to
3fb2708
Compare
@saurabh6790 added some fixes:
|
Issue:
When we set Salary Based On Timesheet attr on Salary Structure or on Payroll Entry, the system hides the field Payroll Frequency.
On Salary Structure the default frequency it Monthly. But as field is hidden there is no way that user will understand this. So at the time of fetching employees on payroll entry, the system were throwing error "Employees not found for selected criteria's"
This issue is due to multiple small issues
Fix:
no-docs