Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if approver is set before sharing doc (backport #590) #605

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix: check if approver is set before sharing doc (backport #590) #605

merged 1 commit into from
Jun 16, 2023

Commits on Jun 16, 2023

  1. fix: share submit permission self (#590) 

    While creating a leave application, if the employee doesn't have a leave approver set, the document is shared with the leave applicant himself by the share API as the approver is `None`.

The Applicant ends up getting submit permission for leave application accidentally but cannot submit it as the "status" field is read-only and has perm level set.

Video:
https://github.com/frappe/hrms/assets/76736615/580b6ceb-9881-4801-b422-9e428ccf15f3

(cherry picked from commit eec8f43)
    @niyazrazak @mergify
    niyazrazak authored and mergify[bot] committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a56ce87 View commit details
    Browse the repository at this point in the history