fix: check if approver is set before sharing doc (backport #590) #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
While creating a leave application, if the employee doesn't have a leave approver set, the document is shared with the leave applicant himself by the share API as the approver is `None`. The Applicant ends up getting submit permission for leave application accidentally but cannot submit it as the "status" field is read-only and has perm level set. Video: https://github.com/frappe/hrms/assets/76736615/580b6ceb-9881-4801-b422-9e428ccf15f3 (cherry picked from commit eec8f43)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version-14-hotfix #605 +/- ##
=====================================================
+ Coverage 72.84% 72.87% +0.02%
=====================================================
Files 191 191
Lines 9898 9897 -1
=====================================================
+ Hits 7210 7212 +2
+ Misses 2688 2685 -3
|
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
## [14.4.4](v14.4.3...v14.4.4) (2023-06-20) ### Bug Fixes * check if approver is set before sharing doc (backport [#590](#590)) ([#605](#605)) ([1902872](1902872)) * cost center mapping in Bank Entry ([d3a5a6a](d3a5a6a)) * translate strings in `job_applicant_dashboard` (backport [#594](#594)) ([#596](#596)) ([903e961](903e961))
|
🎉 This PR is included in version 14.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #590 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com