Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #2408

Closed
wants to merge 1 commit into from
Closed

Conversation

akashdubey22
Copy link

Adding the following lines removes warning displayed while bench update

"dependencies": {
"html2canvas": "^1.4.1",
"workbox-build": "^7.0.0",
"workbox-window": "^7.0.0",
"@tiptap/pm": "^2.6.6",
"@tiptap/core": "^2.6.6"
}

Adding the following lines removes warning displayed while banch update

"dependencies": {
  "html2canvas": "^1.4.1",
  "workbox-build": "^7.0.0",
  "workbox-window": "^7.0.0",
  "@tiptap/pm": "^2.6.6",
  "@tiptap/core": "^2.6.6"
  }
Copy link
Member

@ruchamahabal ruchamahabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this since these are not dependencies of the main app. They are dependencies of the “frontend” PWA submodule.

workbox-build and window already get added as peer dependencies in the frontend package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants