fix(Income Tax Computation): consideration of new employees without preexisting salary slips #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rexisting salary slips
krantheman
added a commit
that referenced
this pull request
Sep 18, 2024
…2197 fix(Income Tax Computation): consideration of new employees without preexisting salary slips (backport #2197)
krantheman
added a commit
that referenced
this pull request
Sep 18, 2024
…2197 fix(Income Tax Computation): consideration of new employees without preexisting salary slips (backport #2197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating the Income Tax Computation report, if an employee does not have pre-existing salary slips, the system looks for salary structure assignments on or before the selected Payroll Period start date. But an employee might not have a salary structure assignment till from when they joined, which could be after the aforementioned Payroll Period start date. In such a case, the system throws an error.
This PR fixes this by looking for assignments on or before the date of joining for such employees.