fix: Attendance Request as a draft for a future date

[Nihantra-Patel]

version 15

fixes: #1957

Before:

• They can't save the Attendance Request for a future date.

After:

• They can now save the Attendance Request as a draft for a future date, but they cannot submit it. Submitting the Attendance Request creates an Attendance record, which has a validation that prevents submissions for future dates.

[ruchamahabal]

This validation checks if to_date is less than from_date
Attendance Request does not have an explicit validation for future dates, I think. It's only in the Attendance doctype

[Nihantra-Patel]

okay, you want to say that we have to add a new custom validation to the attendance request and simply remove the "future dates are not valid" validation. right?

new validation like

def validate_dates_for_ar(doc, from_date, to_date):
    date_of_joining, relieving_date = frappe.db.get_value(
        "Employee", doc.employee, ["date_of_joining", "relieving_date"]
    )
    if getdate(from_date) > getdate(to_date):
        frappe.throw(_("To date cannot be less than from date"))
    elif date_of_joining and getdate(from_date) < getdate(date_of_joining):
        frappe.throw(_("From date cannot be less than employee's joining date"))
    elif relieving_date and getdate(to_date) > getdate(relieving_date):
        frappe.throw(_("To date cannot be greater than employee's relieving date"))

[krantheman]

Closing this as #2292 has been merged.