fix(SalarySlip): get lwp or ppl when payroll calculated based on leave #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting Attendance dates that are linked with Leave Application that the Leave Type is lwp or ppl between Salary Slip date range, to solve overlapping dates between Leave Application and Salary Slip.
|
Please fix your commit message and add a test. |
…_lwp_or_ppl_based_on_leave_application
KerollesFathy
force-pushed
the
fix/get-lwp-or-ppl-for-date-range
branch
from
afd0fa1
to
92003ed
Compare
|
We appreciate your desire to contribute to Frappe HR; however, we ask that you open a PR for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting Attendance dates that are linked with Leave Application that the Leave Type is lwp or ppl between Salary Slip date range, to solve overlapping dates between Leave Application and Salary Slip.
Closes #1874