-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Leave Policy Assignment): calculation of months passed since from_date #1269
Merged
krantheman
merged 5 commits into
frappe:develop
from
krantheman:fix-leave-policy-assignment
Oct 14, 2024
Merged
fix(Leave Policy Assignment): calculation of months passed since from_date #1269
krantheman
merged 5 commits into
frappe:develop
from
krantheman:fix-leave-policy-assignment
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test for this
krantheman
force-pushed
the
fix-leave-policy-assignment
branch
from
January 9, 2024 14:09
977c3f3
to
031137a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1269 +/- ##
===========================================
+ Coverage 72.44% 72.45% +0.01%
===========================================
Files 201 201
Lines 10974 10978 +4
===========================================
+ Hits 7950 7954 +4
Misses 3024 3024
|
This was referenced Oct 15, 2024
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1057; Closes: #121
This PR fixes the incorrect calculation of passed months (for over a year) used in the calculation of total earned leaves.
no-docs