Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Leave Policy Assignment): calculation of months passed since from_date #1269

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

krantheman
Copy link
Member

@krantheman krantheman commented Jan 8, 2024

Closes: #1057; Closes: #121

This PR fixes the incorrect calculation of passed months (for over a year) used in the calculation of total earned leaves.

no-docs

Copy link
Member

@ruchamahabal ruchamahabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for this

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3aad944) 72.44% compared to head (dd9af8e) 72.45%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1269      +/-   ##
===========================================
+ Coverage    72.44%   72.45%   +0.01%     
===========================================
  Files          201      201              
  Lines        10974    10978       +4     
===========================================
+ Hits          7950     7954       +4     
  Misses        3024     3024              
Files Coverage Δ
...leave_policy_assignment/leave_policy_assignment.py 88.30% <100.00%> (+0.28%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants