Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: comment box #2151

Merged
merged 12 commits into from
Jan 28, 2025
Merged

refactor: comment box #2151

merged 12 commits into from
Jan 28, 2025

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Jan 23, 2025 •
edited
Loading

Issue:

  1. Currently, we use v-html for the content box, resulting in an overflow of the ticket like this.
Screenshot 2025-01-23 at 6 28 59 PM
  1. Because of this we can't edit the comment.
  2. No attachments are shown in the UI.
  3. Make Ticket agent activities typesafe.
Comment.Box.mov

@RitvikSardana RitvikSardana merged commit 9ecf7c4 into frappe:develop Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RitvikSardana