Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend disallowSkip option #44

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mariusbuescher
Copy link

This adds the direcitonal skip feature to the player.

@mariusbuescher mariusbuescher changed the title Extend disallowSkip option #43 Extend disallowSkip option Jun 23, 2014
@mariusbuescher
Copy link
Author

Sorry for the duplicate. My bad.

@rwlodkowski
Copy link
Collaborator

@mariusbuescher thanks for that. I think it'll be nice addition to the projekktor functionality. One thing, please push only the relevant changes and remove all the whitespace changes you've done. Thank you.

@rwlodkowski
Copy link
Collaborator

And remove console.log :)

@rwlodkowski
Copy link
Collaborator

@mariusbuescher there is much more things to do to with that functionality.

Please add relevant changes to:

  • setActiveItem and setFrame functions in projekktor.js
  • updateDisplay and scrubberdragStartDragListener functions in projekktor.controlbar.js

You should also add comments in projekktor.config.js for that setting.

@mariusbuescher
Copy link
Author

I don't think there is a need for implementing the functionality in scrubberdragStartDragListener because it calls a function where the check is done. Also you can only do it after the mouse event is called, so there is not such a big issue on performance here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants