forked from hannesha/it87
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Packaging and CI Tools #9
Draft
WinkelCode
wants to merge
10
commits into
frankcrawford:master
Choose a base branch
from
WinkelCode:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinkelCode
force-pushed
the
master
branch
2 times, most recently
from
May 8, 2023 10:05
add28e9
to
0c8ab11
Compare
I’ll squash all the minor documentation edits together at some point |
@WinkelCode thanks for this. Obviously, I'm going to need to review it before we can finalise it, but since you are still working on it, that shouldn't be a problem. |
@WinkelCode how is this going? I haven't really had a chance to look at it so far. |
Test123
Tab -> Spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4
I am basically done with the packaging side of things. I comprehensively tested commit 0334fd6ca4bac3933df7406d19734f1a0900dbc3 on Alpine, Ubuntu and Fedora Silverblue on my PC with IT8688E and IT8795E chips. I have made some minor changes since then but nothing that should change functionality in a major way.
New stuff:
packagetool.sh
Overview/quick start guide: https://github.com/WinkelCode/it87/blob/master/packagetool_quickstart.md
GitHub Actions Workflow
packagetool.sh
wrapperpackagetool.sh
from GitHub actions.Auto package, test, and release
I introduced an automatic workflow that on push to the
master
branch:snapshot-
release (to avoid having multiple unpublished releases)The developer workflow basically looks like this:
[skip ci]
in the commit messageExample: https://github.com/WinkelCode/it87/releases/tag/snapshot-2023-05-08T11_21_23Z
Note: The release publishing part was done with
jq
andcurl
, since all premade Actions for GitHub Releases which I tried had some dealbreaking issue. Error handling isn't comprehensive, but has so far correctly failed the workflow if the API responds with an error code (curl
-f
option).Updated documentation:
Reworked README
https://github.com/WinkelCode/it87/blob/master/README.md
Review/help requests
I would really appreciate it if other people could help review the following items:
Readme
README_old.txt
), some information is likely to be outdated.Example: Can't find
IT8528E
;IT8795E
is in code but not in Sep 2022 list.Packagetool quickstart
Packagetool
./packagetool.sh --print_repo_info
values?Edits by maintainers on my fork are allowed.