Reporting time #11
Closed
Reporting time #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I don't see where we use the execution time in the reporting. Is it missing? |
|
I'm not using it in the reporting because I think it's a bit messy to print all the execution times for each test (mocha doesn't do that either). Also, Go default runner already prints the total execution time for each *_test.go file when -v parameter is provided. I've implemented it as it's needed by issue #9. |
|
Ok. Haven't seen issue #9 Even if it repeats the information provided by go test |
|
Perfect, I'll add it to the reporter then. I'll send the PR again when it's done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add execution time per test to reporting. Resolves #1