Use CookieManager from javafx #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It supports RFC-6265 cookies which account.xiaomi.com server is using. * Scan login cookies after each successful navigation. Unfortunately, this CookieManger does not provide public API to retrieve stored cookies. So we parse them by hand from the Cookie header. * This commit fixes login by QR-code.
* Reset default CookieHandler on logout. The javafx.web module should reinstantiate it as its CookieManager before loading first web page.
nazarewk
added a commit
to nazarewk/XiaoMiToolV2
that referenced
this pull request
Feb 28, 2023
francescotescari#41 - login URL fix francescotescari#94 - Use CookieManager from javafx francescotescari#67 - update JavaFX to show captcha properly finishes with: Failed to unlock your device, Xiaomi server returned error 20045: Error descripiton: Unknown error: 20045 Server description: Please use common user tool on the official website
* The Mi Unlock app sends web requests with "miNative/1.0" user agent string. * Simulate this so that the server would send confirmation codes. If we don't, user is unable to login.
fisuri
approved these changes
Mar 18, 2023
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use com.sun.webkit.network.CookieManager provided by javafx, not java.net.CookieManager which is not capable of processing RFC 6265 styled cookies. I believe the tool should not access cookies individually and, instead, store them as a whole in a CookieJar. But we are where we are.
Nevertheless, this patch fixes login by QR code.
Closes: #64