Merge pull request #14 from frack113/refactor/comments

Refactor/comments

Cargo.toml

@@ -8,8 +8,6 @@ version = "1.0.0"
 edition = "2021"
 description = "Windows Artefact Generator"
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
-
 [profile.release]
 opt-level = 3
 debug = false

build.rs

@@ -2,15 +2,12 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-// build.rs
-
 use winres::{self, WindowsResource};
 
 fn main() {
     if cfg!(target_os = "windows") {
         let mut res: WindowsResource = winres::WindowsResource::new();
 
-        //res.set_icon("rust.ico");
         res.set("FileVersion", "1.0.0");
         res.set("InternalName", "🔓 your detection");
         res.set("CompanyName", "Frack113");

src/cli.rs

@@ -2,17 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-/*
- the cli option
-
- Global
- --help -h
- --module -m
- --get -g
- --detail -d
-
-*/
-
 use crate::malware::ads::ADS;
 use crate::malware::file::FileCreate;
 use crate::malware::mutex::Mutex;

src/main.rs

@@ -2,15 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-/*
- ____ ____ ____ ____ ____ ____ ____ _________ ____ ____ ____ ____ ____ ____ ____ ____ _________ ____ ____ ____ ____ ____ ____ ____ ____ ____
-||W |||i |||n |||d |||o |||w |||s |||       |||A |||r |||t |||e |||f |||a |||c |||t |||       |||G |||e |||n |||e |||r |||a |||t |||o |||r ||
-||__|||__|||__|||__|||__|||__|||__|||_______|||__|||__|||__|||__|||__|||__|||__|||__|||_______|||__|||__|||__|||__|||__|||__|||__|||__|||__||
-|/__\|/__\|/__\|/__\|/__\|/__\|/__\|/_______\|/__\|/__\|/__\|/__\|/__\|/__\|/__\|/__\|/_______\|/__\|/__\|/__\|/__\|/__\|/__\|/__\|/__\|/__\|
-
-Working date:  2023-08
-*/
-
 mod cli;
 mod malware;
 

src/malware/ads.rs

@@ -2,7 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-//
 // Alternate Data Stream
 //
 // Last update 20240224

src/malware/mutex.rs

@@ -2,7 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-//
 // Mutex
 //
 // Last update 20240224

src/malware/namepipe.rs

@@ -2,7 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-//
 // Name Pipe
 //
 // Last update 20240224

src/malware/ppid.rs

@@ -2,7 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-//
 // PPID Spoofing
 //
 // Last update 20240224
@@ -38,7 +37,6 @@ pub struct PPID {
     executable: String,
 }
 
-/* Use internal rust command */
 fn get_user_pid() -> u32 {
     let s: System = System::new_all();
     let mut ppid_list: Vec<u32> = Vec::<u32>::new();

src/malware/service.rs

@@ -2,21 +2,17 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-//
 // Load Vulnerable Driver
 //
 // Last update 20240224
 
-// Windows API
 use windows::core::{Result as WindowsResult, PCWSTR};
 use windows::Win32::Security::SC_HANDLE;
 use windows::Win32::System::Services::{
     ControlService, CreateServiceW, DeleteService, OpenSCManagerW, StartServiceW,
     ENUM_SERVICE_TYPE, SC_MANAGER_ALL_ACCESS, SERVICE_CONTROL_STOP, SERVICE_ERROR,
     SERVICE_START_TYPE, SERVICE_STATUS,
 };
-
-// Some others
 use crate::malware::tools::{process_is_admin, EXIST_ALL_GOOD, EXIST_TEST_ERROR};
 use clap::Parser;
 use std::{thread, time};
@@ -84,7 +80,6 @@ fn create_driver_service(name: &String, details: &String, path: &String) -> bool
             };
         }
         Err(value) => {
-            // let error_code = unsafe { GetLastError() };
             println!("Service Start failure with code : {:#06x}", value.code().0);
         }
     };

src/malware/tools/mod.rs

@@ -2,10 +2,6 @@
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
-//
-// Tools box
-//
-// std::process::exit need a i32
 pub const EXIST_ALL_GOOD: i32 = 0;
 pub const EXIST_CLI_ERROR: i32 = 10;
 pub const EXIST_TEST_ERROR: i32 = 11;
@@ -15,7 +11,6 @@ use std::collections::HashSet;
 use regex_generate::{Generator, DEFAULT_MAX_REPEAT};
 use windows::Win32::UI::Shell::IsUserAnAdmin;
 
-// File Creation
 pub fn hex_to_bytes(s: &str) -> Option<Vec<u8>> {
     if s.len() % 2 == 0 {
         (0..s.len())
@@ -30,9 +25,6 @@ pub fn hex_to_bytes(s: &str) -> Option<Vec<u8>> {
     }
 }
 
-/*
-Some usefull fn
-*/
 pub fn regex_to_string(name: &String) -> String {
     let mut gen: Generator<rand::rngs::ThreadRng> =
         Generator::new(name, rand::thread_rng(), DEFAULT_MAX_REPEAT).unwrap();