Make all tests pass #2
Annotations
10 errors and 5 warnings
golangci-lint:
go/cmd/glox/glox_test.go#L48
badCall: suspicious Join on 1 argument (gocritic)
|
golangci-lint:
go/cmd/glox/glox_test.go#L63
unnecessary trailing newline (whitespace)
|
golangci-lint:
go/cmd/glox/glox_test.go#L51
Function TestRunFile missing the call to method parallel
|
golangci-lint:
go/cmd/glox/glox_test.go#L52
Range statement for test TestRunFile missing the call to method parallel in test Run
|
golangci-lint:
go/cmd/glox/glox_test.go#L65
test helper function should start from t.Helper() (thelper)
|
golangci-lint:
go/cmd/glox/glox_test.go#L101
error returned from external package is unwrapped: sig: func os.ReadFile(name string) ([]byte, error) (wrapcheck)
|
golangci-lint:
go/cmd/glox/glox_test.go#L117
error returned from external package is unwrapped: sig: func github.com/pkg/diff.Text(aFile string, bFile string, a interface{}, b interface{}, w io.Writer, options ...github.com/pkg/diff/write.Option) error (wrapcheck)
|
golangci-lint:
go/cmd/glox/glox_test.go#L133
error returned from external package is unwrapped: sig: func github.com/pkg/diff.Text(aFile string, bFile string, a interface{}, b interface{}, w io.Writer, options ...github.com/pkg/diff/write.Option) error (wrapcheck)
|
golangci-lint:
go/pkg/loxerror/jsonformatter.go#L25
do not define dynamic errors, use wrapped static errors instead: "errors.New(\"empty error stack\")" (err113)
|
golangci-lint:
go/pkg/loxerror/formatter.go#L4
interface method PushError must have named param for type LoxError (inamedparam)
|
golangci-lint:
go/pkg/loxerror/jsonformatter.go#L9
var-naming: type JsonErrorFormatter should be JSONErrorFormatter (revive)
|
golangci-lint:
go/pkg/loxerror/jsonformatter.go#L13
var-naming: func NewJsonErrorFormatter should be NewJSONErrorFormatter (revive)
|
golangci-lint:
go/pkg/loxerror/jsonformatter.go#L38
var-naming: don't use underscores in Go names; var raw_string should be rawString (revive)
|
golangci-lint:
go/pkg/ast/printer.go#L9
exported: type name will be used as ast.AstPrinter by other packages, and that stutters; consider calling this Printer (revive)
|
golangci-lint:
go/pkg/ast/printer.go#L158
unused-parameter: parameter 'thisExpression' seems to be unused, consider removing or renaming it as _ (revive)
|