This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
New example: Confluence #304
Open
Magicloud
wants to merge
1
commit into
master
Choose a base branch
from
confluence
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magicloud
changed the title
Enable attach ELB to single node ASG.
New example: Confluence
Mar 1, 2020
Magicloud
force-pushed
the
confluence
branch
5 times, most recently
from
March 1, 2020 02:41
f0378d7
to
0b468b2
Compare
Magicloud
force-pushed
the
confluence
branch
3 times, most recently
from
March 3, 2020 15:25
e35629b
to
25f16a7
Compare
Plan
|
ketzacoatl
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ketzacoatl
suggested changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get the dependent PRs merged and update the references in this PR.
mcgirr
reviewed
Mar 4, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
mcgirr
reviewed
Mar 5, 2020
Magicloud
force-pushed
the
confluence
branch
3 times, most recently
from
March 6, 2020 02:59
25f16a7
to
03552c9
Compare
@Magicloud please review/update. |
@ketzacoatl The module ref in this example are all fixed. The example itself is ready to merge. |
7 tasks
The example runs Confluence Docker image in a single node ASG, with a RDS, and two ALBs (internal and external). The ALBs have domain names set, and TLS cert (from ACM).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example runs Confluence Docker image in a single node ASG, with a RDS, and two ALBs (internal and external). The ALBs have domain names set, and TLS cert (from ACM).
Deps:
name: Pull request template
about: Make a PR to terraform-aws-foundation
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modules
this would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.