This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Credstash grant #266
Open
Credstash grant #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context with `map`. The original way of creating map at runtime from two lists are easy to go wrong, and acturally wrong. It went through the lists by role count, which does not make sense.
…context with `map`. The original way of creating map at runtime from two lists are easy to go wrong, and acturally wrong. It went through the lists by role count, which does not make sense.
|
Should we also drop cc @Magicloud / @qrilka |
|
@ketzacoatl yes, that was one of my proposals, just put it into a list of objects with names and ARNs. The current approach is quite awkward and error prone |
|
I am with removing "role_count". But seeing that comment, "circumvent issue", the issue is still open (for a few years....). @ketzacoatl Is that issue fixed or unrelated now, especially we are on 0.12 now. |
|
@Magicloud what are next steps for this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed mock data planning. Fixes #265.