-
Notifications
You must be signed in to change notification settings - Fork 97
Active Directory with seamless Windows EC2 join (from ASG) #253
base: master
Are you sure you want to change the base?
Conversation
@ketzacoatl Proof that it actually works is documented on the README (with snapshots): https://github.com/fpco/terraform-aws-foundation/blob/6fd06a686c6f17f27d3374e3207523f499ce14fe/examples/ad-asg/README.md |
# Active Directory with seamless Windows EC2 join (from ASG) | ||
|
||
The terraform code is built on top of | ||
[vpc-scenario1](https://docs.aws.amazon.com/vpc/latest/userguide/VPC_Scenario1.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would VPC Scenario 2 work here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ketzacoatl It will work, but it will require some slight modifications.
[ASG](https://docs.aws.amazon.com/autoscaling/ec2/userguide/AutoScalingGroup.html) | ||
seamlessly joins an Active directory when it gets newly spawned. The | ||
only difference between this example and the [ad-ec2](../ad-ec2) is | ||
that this example uses ASG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include all of the EC2/ASG/windows/linux variants in one single example? and do the "across VPCs" in a second example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel having different example more clearly explains the differences. But I don't have strong opinion on that.
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modules
this would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.