Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Active Directory with seamless Windows EC2 join (from ASG) #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

psibi
Copy link
Member

@psibi psibi commented Sep 19, 2019

Please include the following in your PR:

Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.

  • Update the changelog
  • Make sure that modules and files are documented. This can be done inside the module and files.
  • Make sure that new modules directories contain a basic README.md file.
  • Make sure that the module is added to tests/main.tf
  • Make sure that the linting passes on CI.
  • Make sure that there is an up to date example for your code:
    - For new modules this would entail example code for how to use the module or some explanation in the module readme.
    - For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
  • Make sure that there is a manual CI trigger that can test the deployment.

@psibi
Copy link
Member Author

psibi commented Dec 6, 2019

@ketzacoatl Proof that it actually works is documented on the README (with snapshots): https://github.com/fpco/terraform-aws-foundation/blob/6fd06a686c6f17f27d3374e3207523f499ce14fe/examples/ad-asg/README.md

# Active Directory with seamless Windows EC2 join (from ASG)

The terraform code is built on top of
[vpc-scenario1](https://docs.aws.amazon.com/vpc/latest/userguide/VPC_Scenario1.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would VPC Scenario 2 work here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ketzacoatl It will work, but it will require some slight modifications.

[ASG](https://docs.aws.amazon.com/autoscaling/ec2/userguide/AutoScalingGroup.html)
seamlessly joins an Active directory when it gets newly spawned. The
only difference between this example and the [ad-ec2](../ad-ec2) is
that this example uses ASG.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include all of the EC2/ASG/windows/linux variants in one single example? and do the "across VPCs" in a second example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel having different example more clearly explains the differences. But I don't have strong opinion on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants