-
Notifications
You must be signed in to change notification settings - Fork 97
Add multip-port-sg module #252
base: master
Are you sure you want to change the base?
Conversation
The main motivation for this module is the fact that TF 0.12 doesn't allow for_each to be used with modules (though the argument is already reserved for future versions). Because of that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates:
- add example to the doc
- update
tests/main.tf
to include this module with empty params
@@ -0,0 +1,3 @@ | |||
## Multiple Port Security Group Rule | |||
|
|||
Create an `aws_security_group_rule` to allow ingress on some ports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an example of how you intend the module to be used.
type = set(string) | ||
default = [] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate the above into a variables.tf
protocol = "udp" | ||
cidr_blocks = var.cidr_blocks | ||
security_group_id = var.security_group_id | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
name: Multip-port security group module
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modules
this would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.