Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify digest field names across the project #982

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Jan 8, 2025

Currently the record field names digest and digests are used interchangeably, which is inconsistent. This PR replaces all occurrences of digests with digest.

This eases the use of a strict dissect Elasticsearch mapping.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (6770095) to head (1a0570e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   77.72%   76.24%   -1.48%     
==========================================
  Files         326      326              
  Lines       28571    28571              
==========================================
- Hits        22206    21784     -422     
- Misses       6365     6787     +422     
Flag Coverage Δ
unittests 76.24% <ø> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 214b438 into fox-it:main Jan 9, 2025
17 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/digest-field-names branch January 9, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants