Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Mssql errorlog plugin more robust #978

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Make Mssql errorlog plugin more robust #978

merged 5 commits into from
Jan 2, 2025

Conversation

Horofic
Copy link
Contributor

@Horofic Horofic commented Dec 19, 2024

Fixes #977

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (f2f50a5) to head (2fa52c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/log/mssql.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   77.72%   77.72%   -0.01%     
==========================================
  Files         326      326              
  Lines       28575    28571       -4     
==========================================
- Hits        22210    22206       -4     
  Misses       6365     6365              
Flag Coverage Δ
unittests 77.72% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dissect/target/plugins/os/windows/log/mssql.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/log/mssql.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/log/mssql.py Outdated Show resolved Hide resolved
@Horofic Horofic requested a review from Schamper December 19, 2024 13:55
@Horofic Horofic requested a review from Schamper January 2, 2025 09:47
@Horofic Horofic merged commit 6770095 into main Jan 2, 2025
17 of 20 checks passed
@Horofic Horofic deleted the fix_mssql_errorlog branch January 2, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mssql errorlog plugin fails unexpectedly during compatibility check
2 participants