Add warning for OBJECT_UNUSED in journal plugin #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add a unit test? |
|
Unfortunately we do not have a journal file we can share with |
|
Would it be possible to fabricate one with some hex editing or a cstruct write? |
|
We have added a modified journal file in 3dc6d25. |
JSCU-CNI
force-pushed
the
fix/journal-plugin-unused-struct
branch
from
35ff3db to
3dc6d25
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 77.74% 77.76% +0.01%
==========================================
Files 327 327
Lines 28623 28627 +4
==========================================
+ Hits 22254 22261 +7
+ Misses 6369 6366 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check for ObjectType
OBJECT_UNUSEDwhen iterating to a new journal entry array. It is possible that space is allocated in a journal file which is not yet used to store the next entry array (e.g. the object resides in memory and is not yet flushed to disk). The plugin would then attempt to read this empty data and return aValueErrorsince it is not expecting a zero byte.We have changed this to a warning and added a break to stop iterating since this ObjectType can only be encountered at the end of a journal file.