Add Unix DHCP lease file parser for target.ips
#965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSCU-CNI
force-pushed
the
feature/unix-dhcp-lease
branch
from
b39a4ab to
e256473
Compare
Horofic
requested changes
Dec 6, 2024
Co-authored-by: Stefan de Reuver <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 77.71% 77.72% +0.01%
==========================================
Files 326 326
Lines 28559 28575 +16
==========================================
+ Hits 22194 22210 +16
Misses 6365 6365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Horofic
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR open sources a function called
parse_unix_dhcp_leaseswhich aids in finding DHCP IP addresses on Linux targets (target.ips). It does not implement DHCP parsing for the newlinux.networkplugin and thus partially fixes #960.