Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3325719 - Create a custom admin theme and custom module #82

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JRuiz28
Copy link
Contributor

@JRuiz28 JRuiz28 commented Feb 8, 2023

Ticket

Issue

Testing:

  • Run composer create-project fourkitchens/sous-drupal-project:dev-add-theme-module-custom test --no-interaction and cd test && composer install && lando rebuild.
  • Go to admin/appearance and validate custom theme be there: sous_admin
  • Go to admin/modules and validate custom module be there: sous

@JRuiz28 JRuiz28 self-assigned this Feb 8, 2023
@JRuiz28 JRuiz28 requested a review from ccjjmartin February 8, 2023 23:40
@JRuiz28 JRuiz28 added the 👍 Ready for Review Work is ready for review. label Feb 13, 2023
Copy link
Collaborator

@ccjjmartin ccjjmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JRuiz28 Composer is setup to install everything in the web directory so these will need to be in there and we will need to make sure that we have composer setup to persist these directories upon install. The names of the module and theme I think needs some adjustment, how about:

sous for the module name
sous_admin for the theme name

@ccjjmartin ccjjmartin added bug Something isn't working and removed 👍 Ready for Review Work is ready for review. labels Mar 1, 2023
@JRuiz28 JRuiz28 added 🚧 Work in Progress The PR is a work in progress. and removed bug Something isn't working labels Mar 2, 2023
@JRuiz28
Copy link
Contributor Author

JRuiz28 commented Mar 2, 2023

The changes have been added.
Thank you so much @ccjjmartin for your advice.

Just two details:

  1. The site doesn't seem to recognize the module if it's called just sous, so it's called sous_custom.
  2. The name for the sous_admin theme is apparently already used in the distro and it makes the site not work correctly, so it is also called sous_custom.

@JRuiz28 JRuiz28 requested a review from ccjjmartin March 2, 2023 19:57
@JRuiz28 JRuiz28 added 👍 Ready for Review Work is ready for review. and removed 🚧 Work in Progress The PR is a work in progress. labels Mar 2, 2023
@ccjjmartin
Copy link
Collaborator

@JRuiz28 I am not sure if we need to preserve these paths so composer doesn't wipe them out, so I asked the question here in Slack: https://fourkitchens.slack.com/archives/C07506UNQ/p1678143813991309

@ccjjmartin
Copy link
Collaborator

@JRuiz28
Copy link
Contributor Author

JRuiz28 commented Mar 8, 2023

Composer preserve paths added! 👍🏾

@cbfannin
Copy link
Contributor

@ccjjmartin I was doing some triaging of our issues marked Needs Review on d.o Where did we end up with this issue?

@laura-johnson
Copy link
Contributor

Since this PR was created we have pulled out the distro. We need to make sure it doesn't pull the distro back in, and update the module to D9, and leave out most of the composer.json changes.

@cbfannin cbfannin self-assigned this Aug 9, 2023
@cbfannin cbfannin added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. 👉 Needs Work Reviewer has requested changes. labels Aug 9, 2023
@cbfannin cbfannin added the 🚧 Work in Progress The PR is a work in progress. label Aug 9, 2023
@ccjjmartin ccjjmartin removed their request for review December 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Work in Progress The PR is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants