-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3325719 - Create a custom admin theme and custom module #82
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JRuiz28 Composer is setup to install everything in the web
directory so these will need to be in there and we will need to make sure that we have composer setup to persist these directories upon install. The names of the module and theme I think needs some adjustment, how about:
sous
for the module name
sous_admin
for the theme name
The changes have been added. Just two details:
|
@JRuiz28 I am not sure if we need to preserve these paths so composer doesn't wipe them out, so I asked the question here in Slack: https://fourkitchens.slack.com/archives/C07506UNQ/p1678143813991309 |
Preserve paths: https://github.com/drupal-composer/preserve-paths#example |
Composer preserve paths added! 👍🏾 |
@ccjjmartin I was doing some triaging of our issues marked Needs Review on d.o Where did we end up with this issue? |
Since this PR was created we have pulled out the distro. We need to make sure it doesn't pull the distro back in, and update the module to D9, and leave out most of the composer.json changes. |
Ticket
Issue
Testing:
composer create-project fourkitchens/sous-drupal-project:dev-add-theme-module-custom test --no-interaction
andcd test && composer install && lando rebuild
.admin/appearance
and validate custom theme be there: sous_adminadmin/modules
and validate custom module be there: sous