Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with permanently hidden Campaign Features in Comp Browser #16575

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

DocSchlock
Copy link
Collaborator

Closes #15555

Issue was the campaignFeature sources were getting permanently set to load = false.

I noticed there was no pack settings to toggle it, so I added it and it fixed the issue.

@CarlosFdez
Copy link
Collaborator

I remember hiding campaign features when kingmaker is disabled. Can you also hide the setting along with it?

@DocSchlock
Copy link
Collaborator Author

I remember hiding campaign features when kingmaker is disabled. Can you also hide the setting along with it?

So I took a look: the template's context for settings is narrowed using a with block that excludes showCampaign, the visibility flag.

I would need to unravel the context narrowing - if that's okay, I can do it, but otherwise I'm not sure how to get the flag to the partial's context to correctly hide the pack setting.

EDIT: I guess the other option would be cloning the flag into the settings structure so it can be referenced even with the narrowing.

@DocSchlock
Copy link
Collaborator Author

Decided to go the clone route.

@CarlosFdez
Copy link
Collaborator

CarlosFdez commented Sep 19, 2024

You can always use @root. to get the root one, as well as ../ to go one step up, if that works better with less changes. Otherwise I'd only keep showCampaign at the root level and remove it from the tab settings (accessed via @root.showCampaign) if need be.

@CarlosFdez CarlosFdez merged commit afe50f4 into foundryvtt:master Sep 20, 2024
1 check passed
@DocSchlock DocSchlock deleted the fix-campaign-features branch September 21, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Campaign tab of the compendium browser is empty after changing browser source settings
2 participants