Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implement selection to Thaumaturge Dedication #16265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xyzzy42
Copy link
Contributor

@xyzzy42 xyzzy42 commented Aug 28, 2024

A ChoiceSet will present an implement selection upon taking the Dedication. It does not GrantItem the chosen implement class feature (e.g. Weapon), as none of the implement's benefits are provided yet.

The archetype feat Implement Initiate will GrantItem the chosen implement class feature, using the choice made in the Dedication above. This is when the implement's benefits should show up, e.g. Weapon will grant the action Implement's Interruption.

A ChoiceSet will present an implement selection upon taking the Dedication.  It
does _not_ GrantItem the chosen implement class feature (e.g. Weapon), as none
of the implement's benefits are provided yet.

The archetype feat Implement Initiate will GrantItem the chosen implement class
feature, using the choice made in the Dedication above.  This is when the
implement's benefits should show up, e.g. Weapon will grant the action
Implement's Interruption.
@xyzzy42
Copy link
Contributor Author

xyzzy42 commented Aug 28, 2024

@websterguy came up with the idea. It's an alternative to #14678

The reason 14678 didn't work, was that the GrantItem of the implement feature was in the Dedication feat. That GrantItem controlled if the implement's benefits were granted or not. It needed to be re-evaluated when the Implement Initiate feat is added to the actor. But adding a new feat to the actor doesn't trigger re-evaluation of existing feats.

This avoids that problem by not granting the implement feature until Implement Initiate is added. The GrantItem is in Implement Initiate now. Since none of the implement's benefits are provided until Implement Initiate gives them, it makes sense to not put the feature on the character sheet until it does something.

The implement type is still chosen in the Dedication. The feat says to make the choice at this time. It's also nice for the thaum module, as it would like to know what kind of implement to create even if it doesn't provide any benefits yet.

This is also quite a bit simpler than the 14678 version.

Here's what the feats look like on the character sheet.
image

@pedrogrullada pedrogrullada added the pr: data update Updates to existing actors and items label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants