Skip to content

Commit

Permalink
Condense Investigator Clue In effects (#16666)
Browse files Browse the repository at this point in the history
  • Loading branch information
pedrogrullada authored Sep 24, 2024
1 parent 23990c0 commit 3338c37
Show file tree
Hide file tree
Showing 15 changed files with 1,647 additions and 2,002 deletions.
3 changes: 3 additions & 0 deletions build/uuid-redirects.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,12 @@
"Compendium.pf2e.feat-effects.Item.eA14bUF7xhNCzw2v": "Compendium.pf2e.feat-effects.Item.Effect: Sanctify Armament",
"Compendium.pf2e.feat-effects.Item.o04gwnrVtzWyIEs8": "Compendium.pf2e.feat-effects.Item.Effect: Emblazon Armament",
"Compendium.pf2e.feat-effects.Item.oX51Db6IxnUI64dT": "Compendium.pf2e.feat-effects.Item.Effect: Emblazon Energy",
"Compendium.pf2e.feat-effects.Item.rUKtp4q8y73AvCbo": "Compendium.pf2e.feat-effects.Item.Effect: Clue In",
"Compendium.pf2e.feat-effects.Item.ruRAfGJnik7lRavk": "Compendium.pf2e.feat-effects.Item.Effect: Nymph Blood Magic",
"Compendium.pf2e.feat-effects.Item.uA1Ofqoyi0UiZIPk": "Compendium.pf2e.feat-effects.Item.Effect: Clue In",
"Compendium.pf2e.feat-effects.Item.x4Sb3qaMJo8x1r3X": "Compendium.pf2e.feat-effects.Item.Effect: Emblazon Energy",
"Compendium.pf2e.feat-effects.Item.yfbP64r4a9e5oyli": "Compendium.pf2e.feat-effects.Item.Effect: Demonic Blood Magic",
"Compendium.pf2e.feat-effects.Item.z4pnE8KyUdEkJmru": "Compendium.pf2e.feat-effects.Item.Effect: Clue In",
"Compendium.pf2e.the-slithering-bestiary.Actor.idj4GBmsLUNUbk9r": "Compendium.pf2e.pathfinder-bestiary.Actor.Alchemical Golem",
"Compendium.pf2e.pathfinder-bestiary.Actor.ETwmjdnmSkqGdD5r": "Compendium.pf2e.pathfinder-monster-core.Actor.Animated Broom",
"Compendium.pf2e.pathfinder-bestiary.Actor.wMomrpcaC8QvIdlj": "Compendium.pf2e.pathfinder-monster-core.Actor.Ankhrav",
Expand Down
18 changes: 16 additions & 2 deletions packs/actions/pursue-a-lead.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,25 @@
{
"key": "FlatModifier",
"predicate": [
"pursue-a-lead"
"pursue-a-lead",
{
"or": [
{
"not": "check:type:saving-throw"
},
{
"and": [
"check:type:saving-throw",
"feat:detectives-readiness"
]
}
]
}
],
"selector": [
"perception",
"skill-check"
"skill-check",
"saving-throw"
],
"slug": "pursue-a-lead",
"type": "circumstance",
Expand Down
15 changes: 13 additions & 2 deletions packs/classfeatures/investigator-expertise.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"category": "classfeature",
"description": {
"value": "<p>You've refined your investigative techniques to an exceptional degree. Your circumstance bonus from @UUID[Compendium.pf2e.actionspf2e.Item.Pursue a Lead] increases to +2. Your proficiency rank for your investigator class DC increases to expert.</p>\n<p>@UUID[Compendium.pf2e.feat-effects.Item.Effect: Clue In (Expertise)]</p>\n<p>If you have @UUID[Compendium.pf2e.feats-srd.Item.Detective's Readiness], @UUID[Compendium.pf2e.feat-effects.Item.Effect: Clue In (Detective's Readiness, Expertise)]</p>"
"value": "<p>You've refined your investigative techniques to an exceptional degree. Your circumstance bonus from @UUID[Compendium.pf2e.actionspf2e.Item.Pursue a Lead] increases to +2. Your proficiency rank for your investigator class DC increases to expert.</p>"
},
"level": {
"value": 9
Expand All @@ -25,12 +25,23 @@
"title": "Pathfinder Player Core 2"
},
"rules": [
{
"itemType": "action",
"key": "ItemAlteration",
"mode": "add",
"predicate": [
"item:slug:clue-in"
],
"property": "other-tags",
"value": "investigator-expertise"
},
{
"key": "AdjustModifier",
"mode": "upgrade",
"selectors": [
"perception",
"skill-check"
"skill-check",
"saving-throw"
],
"slug": "pursue-a-lead",
"value": 2
Expand Down

This file was deleted.

45 changes: 0 additions & 45 deletions packs/feat-effects/effect-clue-in-detectives-readiness.json

This file was deleted.

47 changes: 0 additions & 47 deletions packs/feat-effects/effect-clue-in-expertise.json

This file was deleted.

40 changes: 36 additions & 4 deletions packs/feat-effects/effect-clue-in.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,51 @@
"value": 1
},
"publication": {
"license": "OGL",
"remaster": false,
"title": "Pathfinder Advanced Player's Guide"
"license": "ORC",
"remaster": true,
"title": "Pathfinder Player Core 2"
},
"rules": [
{
"key": "FlatModifier",
"predicate": [
{
"or": [
{
"not": "check:type:saving-throw"
},
{
"and": [
"check:type:saving-throw",
"parent:origin:item:tag:detectives-readiness"
]
}
]
}
],
"removeAfterRoll": "if-enabled",
"selector": [
"perception",
"skill-check"
"skill-check",
"saving-throw"
],
"slug": "clue-in",
"type": "circumstance",
"value": 1
},
{
"key": "AdjustModifier",
"mode": "upgrade",
"predicate": [
"parent:origin:item:tag:investigator-expertise"
],
"selectors": [
"skill-check",
"perception",
"saving-throw"
],
"slug": "clue-in",
"value": 2
}
],
"start": {
Expand Down
40 changes: 22 additions & 18 deletions packs/feats/detectives-readiness.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"category": "class",
"description": {
"value": "<p>When you're on a case, you stay watchful and resolute to avoid tricks your suspect might pull. You gain your investigation bonus from Pursue a Lead on saving throws (and their DCs, as normal) against creatures or effects that are related to the question at the heart of an open investigation, and you can use Clue In to assist an ally's saving throw against that creature or effect.</p>\n<p>@UUID[Compendium.pf2e.feat-effects.Item.Effect: Clue In (Detective's Readiness)]</p>"
"value": "<p>When you're on a case, you stay watchful and resolute to avoid tricks your suspect might pull. You gain your investigation bonus from Pursue a Lead on saving throws (and their DCs, as normal) against creatures or effects that are related to the question at the heart of an open investigation, and you can use Clue In to assist an ally's saving throw against that creature or effect.</p>"
},
"level": {
"value": 4
Expand All @@ -26,25 +26,29 @@
},
"rules": [
{
"key": "FlatModifier",
"label": "Pursue a Lead (Detective's Readiness)",
"itemType": "action",
"key": "ItemAlteration",
"mode": "add",
"predicate": [
"pursue-a-lead"
"item:slug:clue-in"
],
"selector": "saving-throw",
"type": "circumstance",
"value": {
"brackets": [
{
"end": 8,
"value": 1
},
{
"start": 9,
"value": 2
}
]
}
"property": "other-tags",
"value": "detectives-readiness"
},
{
"itemType": "action",
"key": "ItemAlteration",
"mode": "add",
"predicate": [
"item:slug:clue-in"
],
"property": "description",
"value": [
{
"divider": true,
"text": "PF2E.SpecificRule.Investigator.DetectivesReadiness.ClueInAddendum"
}
]
}
],
"traits": {
Expand Down
10 changes: 5 additions & 5 deletions packs/iconics/korakai-level-1.json
Original file line number Diff line number Diff line change
Expand Up @@ -3514,11 +3514,11 @@
},
{
"_id": "6FswDuZkuq53n43b",
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.EzB9i7R6aBRAtJCh"
}
},
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.EzB9i7R6aBRAtJCh"
}
},
"img": "icons/magic/water/strike-ice-blade-axe.webp",
"name": "Tempest Touch",
"sort": 0,
Expand Down
10 changes: 5 additions & 5 deletions packs/iconics/korakai-level-3.json
Original file line number Diff line number Diff line change
Expand Up @@ -4426,11 +4426,11 @@
},
{
"_id": "DPeEiaQTnxlmWquq",
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.EzB9i7R6aBRAtJCh"
}
},
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.EzB9i7R6aBRAtJCh"
}
},
"img": "icons/magic/water/strike-ice-blade-axe.webp",
"name": "Tempest Touch",
"sort": 0,
Expand Down
20 changes: 10 additions & 10 deletions packs/iconics/korakai-level-5.json
Original file line number Diff line number Diff line change
Expand Up @@ -5179,11 +5179,11 @@
},
{
"_id": "9sqCZo2FiV6JSZ90",
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.EzB9i7R6aBRAtJCh"
}
},
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.EzB9i7R6aBRAtJCh"
}
},
"img": "icons/magic/water/strike-ice-blade-axe.webp",
"name": "Tempest Touch",
"sort": 0,
Expand Down Expand Up @@ -5275,11 +5275,11 @@
},
{
"_id": "5Dx2wV2hBS00BGgH",
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.g1eY1vN44mgluE33"
}
},
"flags": {
"core": {
"sourceId": "Compendium.pf2e.spells-srd.Item.g1eY1vN44mgluE33"
}
},
"img": "systems/pf2e/icons/spells/charged-javelin.webp",
"name": "Charged Javelin",
"sort": 0,
Expand Down
Loading

0 comments on commit 3338c37

Please sign in to comment.