Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update doc for casm = true in scarb.toml #2619

Merged
merged 7 commits into from
Oct 30, 2024
Merged

doc: update doc for casm = true in scarb.toml #2619

merged 7 commits into from
Oct 30, 2024

Conversation

NueloSE
Copy link
Contributor

@NueloSE NueloSE commented Oct 28, 2024 •
edited by franciszekjob
Loading

Closes #2472

Introduced changes

Add a description about the slow compilation when casm = true in scarb.toml file

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

cptartur
cptartur requested changes Oct 28, 2024
View reviewed changes
docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
@NueloSE NueloSE requested a review from cptartur October 28, 2024 09:36
cptartur
cptartur reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me

docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
@NueloSE NueloSE requested a review from cptartur October 29, 2024 06:51
@NueloSE
Copy link
Contributor Author

NueloSE commented Oct 29, 2024

Hello @cptartur and @ksew1,

Thank you both for your feedback. @cptartur, I have committed your suggestion. I noticed that your final suggestion still includes a link to v0.23.0. Could you confirm if it’s fine to keep this link, or would you prefer I remove it?

franciszekjob
franciszekjob requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessarily added enters.

docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
@NueloSE
Copy link
Contributor Author

NueloSE commented Oct 29, 2024

@franciszekjob @cptartur @ksew1 all enters have been removed. It was as a result of prettier. Apologies for the issues. Ready for review.

franciszekjob
franciszekjob approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cptartur cptartur added this pull request to the merge queue Oct 30, 2024
Merged via the queue into foundry-rs:master with commit 370c3ef Oct 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksew1 ksew1 ksew1 approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur cptartur approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that casm = true in Scarb.toml slows the compilation
4 participants
@NueloSE @cptartur @franciszekjob @ksew1