Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support overriding block id/tag/hash with a named fork binding #2475

Merged
merged 30 commits into from
Sep 23, 2024
Merged

Add support overriding block id/tag/hash with a named fork binding #2475

merged 30 commits into from
Sep 23, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Sep 17, 2024 •
edited
Loading

Relates #2450

Introduced changes

  • Added new fork config resolving option

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula changed the title Add mixed variant for 'fork' configuration Add support overriding block id/tag/hash with a named fork binding Sep 17, 2024
@kkawula kkawula marked this pull request as draft September 17, 2024 12:19
@kkawula kkawula marked this pull request as ready for review September 18, 2024 14:12
@kkawula kkawula requested a review from Draggu September 18, 2024 14:12
@kkawula kkawula added this pull request to the merge queue Sep 19, 2024
@cptartur cptartur removed this pull request from the merge queue due to a manual request Sep 19, 2024
cptartur
cptartur requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, however this is missing documentation, an entry to CHANGELOG.md and most importantly some actual tests verifying this behaves as intended in crates/forge/tests/integration/setup_fork.rs.

crates/snforge-scarb-plugin/src/utils.rs Outdated Show resolved Hide resolved
@kkawula
Copy link
Collaborator Author

kkawula commented Sep 23, 2024

Docs added in #2500

@kkawula kkawula added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit 9791970 Sep 23, 2024
23 checks passed
@kkawula kkawula deleted the kkawula/2450-overriding-named-fork-binding branch September 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksew1 ksew1 ksew1 approved these changes

@integraledelebesgue integraledelebesgue integraledelebesgue approved these changes

@Draggu Draggu Draggu approved these changes

@cptartur cptartur cptartur approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkawula @cptartur @Draggu @ksew1 @integraledelebesgue