Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that casm = true in Scarb.toml slows the compilation #2472

Closed
piotmag769 opened this issue Sep 16, 2024 · 8 comments · Fixed by #2619
Closed

Document that casm = true in Scarb.toml slows the compilation #2472

piotmag769 opened this issue Sep 16, 2024 · 8 comments · Fixed by #2619
Assignees
Labels
documentation Improvements or additions to documentation ODHack9 Label for tasks to be done in the ODHack October sncast snforge

Comments

@piotmag769
Copy link
Member

piotmag769 commented Sep 16, 2024

Which components does the task require to be changed? (think hard pls)

snforge, sncast

Description

We compile every sierra with USC anyways since Scarb gives no guarantee about CASM by design.
The overhead generated by this can be huge for big sierra programs (couple dozens of MB). It was only mentioned changelog of 0.23.0 version. It should be done in this file here

@piotmag769 piotmag769 added documentation Improvements or additions to documentation snforge sncast labels Sep 16, 2024
@github-actions github-actions bot added the new label Sep 16, 2024
@cptartur cptartur removed the new label Sep 17, 2024
@ksew1 ksew1 added the ODHack9 Label for tasks to be done in the ODHack October label Oct 21, 2024
@CollinsC1O
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello I'm a front-end and a blockchain developer and will love to work on this

@NueloSE
Copy link
Contributor

NueloSE commented Oct 24, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Am a technical writer

How I plan on tackling this issue

kindly assign ETA <= 78hrs

@martinvibes
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

hello @ i'm an experienced frontend developer and a blockchain developer i would love to work on this issue
Pleasee kindly assign :)

@Nemezjusz
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I am ICT student and for the last few months i was really intrested in Rust and Cario. I also work professionallyas software developer. I hope can help you solve this and start my journey in Cario world

How I plan on tackling this issue

I’d locate Sierra compilation in snforge and sncast, address the USC and CASM overhead, and review version 0.23.0 changelogs for changes.

@Akshola00
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have a solid background in software development, focusing on blockchain and toolchain optimization. My experience with various compilers, including StarkNet tools, allows me to manage complex build processes effectively. Additionally, my ability to write clear documentation will support updating the changelog and guiding users.

How I plan on tackling this issue

I will analyze how snforge and sncast compile programs to identify delays in large Sierra compilations. I will find ways to improve memory usage, streamline the USC process, and add caching to reduce slowdowns. I will update the documentation and changelog for clear user instructions. Finally, I will thoroughly test the changes for efficiency in both small and large Sierra programs.

@raizo07
Copy link

raizo07 commented Oct 24, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, can I be assigned to work on this issue?

I'm a software developer with over 4 years experience

Here's my OnlyDust profile https://app.onlydust.com/u/raizo07

ETA: One day

@ksew1
Copy link
Collaborator

ksew1 commented Oct 25, 2024

@NueloSE any progress on this?

@NueloSE
Copy link
Contributor

NueloSE commented Oct 25, 2024

@NueloSE any progress on this?

@ksew1, Am still trying to get a better understanding of the above task hope will make a PR over the weekend

currently making some progress on this.

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2472 

## Introduced changes
Add a description about the slow compilation when casm = true in
scarb.toml file

-

## Checklist

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Artur Michałek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ODHack9 Label for tasks to be done in the ODHack October sncast snforge
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants